Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image-reflector API to v1beta2 #485

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Update image-reflector API to v1beta2 #485

merged 1 commit into from
Feb 16, 2023

Conversation

darkowlzz
Copy link
Contributor

No description provided.

@darkowlzz darkowlzz marked this pull request as ready for review February 16, 2023 17:08
hiddeco
hiddeco reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this require an update of the image-reflector image, etc. as well?

hiddeco
hiddeco approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, it does not do something like this: https:/fluxcd/helm-controller/blob/main/config/default/kustomization.yaml#L5-L6

@darkowlzz darkowlzz added the area/ci CI related issues and pull requests label Feb 16, 2023
@darkowlzz darkowlzz merged commit 06cbd06 into main Feb 16, 2023
@darkowlzz darkowlzz deleted the irc-v1beta2 branch February 16, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkowlzz @hiddeco