Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest generation when updating final status #164

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Use latest generation when updating final status #164

merged 1 commit into from
Nov 4, 2020

Conversation

stefanprodan
Copy link
Member

To avoid stale status writes, we use the latest object generation before updating the final status sub-resource.

@stefanprodan stefanprodan added the enhancement New feature or request label Nov 4, 2020
hiddeco
hiddeco approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a note that I am not yet sure this is the most idiomatic way of dealing with this issue, as I am currently in the process of finding this out myself for the Helm Controller.

@stefanprodan stefanprodan merged commit 68df710 into main Nov 4, 2020
@stefanprodan stefanprodan deleted the status-update branch November 4, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco