Refactor: Generate manifests with flux/pkg/kustomize
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
force-pushed
the
use-pkg-kustomize
branch
from
529b2c5
to
eef1e82
Compare
|
The test should pass after #765 is merged. |
|
@souleb please rebase and try again. |
Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
use-pkg-kustomize
branch
from
eef1e82
to
ab04480
Compare
stefanprodan
changed the title
flux/pkg/kustomize
Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
use-pkg-kustomize
branch
from
c6b2722
to
69370f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Soule BA [email protected]
This has to be merged after fluxcd/pkg#392.
If this is implemented, it will use the same code base as
flux build/diff kustomizationfor kustomize generation and variable substitution and will ease maintenance.