Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count garbage collected items #481

Closed
hiddeco opened this issue Nov 1, 2021 · 2 comments · Fixed by #586
Closed

Count garbage collected items #481

hiddeco opened this issue Nov 1, 2021 · 2 comments · Fixed by #586
Labels
area/storage Storage related issues and pull requests enhancement New feature or request

Comments

@hiddeco
Copy link
Member

hiddeco commented Nov 1, 2021

In the reconcilers-dev branch we have started to be more informative about the precise actions that were taken during a reconcile run.

At present, this means that it will tell that it (successfully) run the garbage collection. It would however be more meaningful if we only pushed an event if any items were collected, or a failure occurred.

To be able to determine this, we need to know the number of items that were removed. We could do better however, and at least collect details about the precise items that were removed.

Relevant lines in reconcilers are at present marked with:

// TODO(hidde): we should only push this event if we actually garbage collected something
@hiddeco hiddeco added enhancement New feature or request area/storage Storage related issues and pull requests labels Nov 1, 2021
@cwyl02
Copy link
Contributor

cwyl02 commented Jan 7, 2022

hi @hiddeco I checked out reconcilers-dev to my local but the makefile doesn't seem to work on my Intel MacOs. Do you think it's possible to do a pull rebase from main or cherry-pick #515 to this branch?

@cwyl02
Copy link
Contributor

cwyl02 commented Jan 7, 2022

well I tried to cherry-pick that to reconcilers-dev on my local and encountered merge conflicts. But a copy-paste of Makefile from main just did the trick to at least allow me to run makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants