Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: only use Digest to calculcate index revision #1035

Merged
merged 3 commits into from
Feb 23, 2023
Merged

helm: only use Digest to calculcate index revision #1035

merged 3 commits into from
Feb 23, 2023

Commits on Feb 22, 2023

  1. helm: only use Digest to calculcate index revision 

    In #1001 bits around the Helm repository reconciliation logic were
rewritten, mostly based on the documented behavior instead of the
actual code. This resulted in the reintroduction of a YAML marshal of
the (sorted) index YAML instead of reliance of just the checksum of the
file.

This to take situations into account in which a repository would e.g.
provide a new random order on every generation. However, this approach
is (extremely) expensive as the marshal goes through a JSON -> YAML
loop, eating lots of RAM in the process.

As the further (silently) introduced behavior has not resulted in any
reported issues, I deem this approach safe and better than e.g.
encoding to just JSON which would still require a substantial amount of
memory.

Signed-off-by: Hidde Beydals <[email protected]>
    @hiddeco
    hiddeco committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    c0a1099 View commit details
    Browse the repository at this point in the history

  2. helmrepo: only log recovery msg on actual recovery 

    Signed-off-by: Hidde Beydals <[email protected]>
    @hiddeco
    hiddeco committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    76c4bb7 View commit details
    Browse the repository at this point in the history

  3. internal/helm: del deprecated ChartRepo#Revision 

    Signed-off-by: Hidde Beydals <[email protected]>
    @hiddeco
    hiddeco committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    c712fed View commit details
    Browse the repository at this point in the history