Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.1.x] helmrepo: fix Secret type check for TLS via .spec.secretRef #1225

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

fluxcdbot
Copy link
Member

Automated backport to release/v1.1.x, triggered by a label in #1220.

This is a regression fix introduced in a302c71 which would wrongly check
for the type of the Secret specified in `.spec.secretRef` while
configuring TLS data.

Introduce `LegacyTLSClientConfigFromSecret` which does not check the
Secret type while constructing the TLS config.

Signed-off-by: Sanskar Jaiswal <[email protected]>
(cherry picked from commit f787fc7)
@stefanprodan stefanprodan merged commit 123a087 into release/v1.1.x Sep 7, 2023
10 checks passed
@stefanprodan stefanprodan deleted the backport-1220-to-release/v1.1.x branch September 7, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants