Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ensure proper garbage collection #489

Merged
merged 1 commit into from
Nov 16, 2021
Merged

tests: ensure proper garbage collection #489

merged 1 commit into from
Nov 16, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Nov 16, 2021

  • Ensure the proper path is garbage collected for libgit2 repositories,
    as the Path method on the repository object returns the .git
    directory, and not the root path.
  • Ensure the Helm test server does not get swapped during tests,
    with as side-effect that no obsolete temporary directories remain.

- Ensure the proper path is garbage collected for libgit2 repositories,
  as the `Path` method on the repository object returns the `.git`
  directory, and not the root path.
- Ensure the Helm test server does not get swapped during tests,
  with as side-effect that no obsolete temporary directories remain.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco added the area/ci CI related issues and pull requests label Nov 16, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did notice some of these related directories in my /tmp dir.
Thanks. LGTM!

@hiddeco hiddeco merged commit 4677bfd into main Nov 16, 2021
@hiddeco hiddeco deleted the test-gc-fixes branch November 16, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants