Support air-gapped, offline, or otherwise customized install manifests #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I please request a review of this feature? |
darkowlzz
reviewed
Nov 6, 2023
There was a problem hiding this comment.
@vanveele sorry for the late review.
I tested this change and verified that it works when a different manifests path address is passed with a different version.
Left a comment about the implementation based on the failing tests. Once that's resolved, we should be good to merge this. Also, can you please rebase the changes to a single commit?
Thanks for implementing this.
NOTE: Since it has been a long time, if you can't take it forward, please let me know. I can update it based on my suggestions and get it merged.
Signed-off-by: Robert van Veelen <[email protected]>
11 tasks
|
This solution for air-gapped has been deprecated! All users are advised to use #664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter to set the equivalent flux bootstrap arg "manifestsPath" seen here.
This is useful in cases where access to github.com (the default value) is blocked or unavailable. I have used names matching those used in flux2.