Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic due to missing configuration #509

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix panic due to missing configuration #509

merged 1 commit into from
Jul 5, 2023

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Jul 5, 2023

This adds a check for the provider resource data in all of the methods of bootstrap git resource that require the Git and Kubernetes configuration to run.

Missing configuration results in the following:

Plan: 1 to add, 0 to change, 0 to destroy.

│ Error: Missing configuration

│   with flux_bootstrap_git.this,
│   on main.tf line 48, in resource "flux_bootstrap_git" "this":
│   48: resource "flux_bootstrap_git" "this" {

│ Git and Kubernetes configuration not found

Fixes #508

@darkowlzz darkowlzz marked this pull request as ready for review July 5, 2023 13:50
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @darkowlzz

@darkowlzz darkowlzz merged commit fc76337 into main Jul 5, 2023
@darkowlzz darkowlzz deleted the res-data-panic branch July 5, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin v1.0.0-rc.5 crashed
2 participants