Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Provider can deploy to pre-existing namespace #577

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Nov 28, 2023

If flux-system already exists, then the provider will
use it as scope for installation of Flux manifests.

It seems important to document this behaviour to
indicate there is no need for to add a boolean
e.g. create_namespace=true|false.


I have just tested this behaviour myself using flux_bootstrap_git against pre-existing flux-system namespace with pre-existing Secret with Git SSH credentials:

resource "flux_bootstrap_git" "gitops" {
  path      = "clusters/test"
  namespace = "flux-system"

  disable_secret_creation = true
  secret_name             = local.flux_github_secret
}

@mloskot mloskot force-pushed the ml/docs-namespace-can-pre-exist branch from 975b057 to e394e41 Compare November 28, 2023 17:22
If `flux-system` already exists, then the provider will
use it as scope for installation of Flux manifests.

It seems important to document this behaviour to
indicate there is no need for to add a boolean
e.g. `create_namespace=true|false`.

Signed-off-by: Mateusz Łoskot <[email protected]>
@mloskot mloskot force-pushed the ml/docs-namespace-can-pre-exist branch from e394e41 to 1124c38 Compare November 28, 2023 17:23
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mloskot

@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Nov 28, 2023
@stefanprodan stefanprodan merged commit f22f467 into fluxcd:main Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants