Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples, simplified documentation and adding pre-commit to CI #616

Merged
merged 17 commits into from
Mar 27, 2024
Merged

Updated examples, simplified documentation and adding pre-commit to CI #616

merged 17 commits into from
Mar 27, 2024

Conversation

swade1987
Copy link
Member

Towards #615

Context
This pull request addresses an issue where the links in the docs directory were not functional from the Terraform Registry perspective. The Terraform Registry requires legitimate, fully qualified URLs to render documentation correctly, necessitating these links to be accurate and accessible upon merging to the main branch. To maintain high standards of documentation and code, this PR also introduces a series of examples, integrates pre-commit checks into our Continuous Integration (CI) process, and incorporates tfplugindocs into our pre-commit hooks.

Changes

  1. Documentation Links: To ensure the documentation links work seamlessly from the Terraform Registry, we've implemented hard-coded URLs that point to the expected locations within the main branch. This approach guarantees the validity and accessibility of the links post-merge.
  2. Examples Addition: A comprehensive range of examples has been added to illustrate our provider's usage and capabilities. These examples aim to provide users with practical guidance and improve their overall experience.
  3. Pre-commit Checks in CI: We've integrated pre-commit checks into our CI pipeline to enhance code quality and ensure that contributions adhere to our coding standards before merging.
  4. tfplugindocs in Pre-commit: Adding tfplugindocs to our pre-commit hooks automates the generation and maintenance of our Terraform documentation, ensuring it remains up-to-date and consistent.

Note for Reviewers
The links within the docs directory are designed to be functional post-merge, as they rely on being legitimate, fully-qualified URLs per the Terraform Registry's requirements. Additionally, the introduction of examples, pre-commit checks, and tfplugindocs represents our commitment to maintaining high quality and usability standards in our project.

@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests area/ux In pursuit of a delightful user experience labels Mar 26, 2024
swade1987 and others added 2 commits March 27, 2024 11:47
Co-authored-by: Stefan Prodan <[email protected]>
Signed-off-by: Steven Wade <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @swade1987 🏅

@stefanprodan stefanprodan merged commit 7e2a3b1 into fluxcd:main Mar 27, 2024
17 checks passed
@swade1987 swade1987 deleted the update-examples branch March 27, 2024 16:29
@fluxcd fluxcd locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation related issues and pull requests area/ux In pursuit of a delightful user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants