Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readiness diagnotics messages #680

Merged
merged 1 commit into from
May 2, 2024

Conversation

errordeveloper
Copy link
Contributor

Before:

Plan: 0 to add, 1 to change, 0 to destroy.
╷
│ Warning: Flux controllers are not healthy and will be redeployed
│ 
│   with module.user_flux.flux_bootstrap_git.flux,
│   on ../../../common/flux/main.tf line 15, in resource "flux_bootstrap_git" "flux":
│   15: resource "flux_bootstrap_git" "flux" {
│ 
│ failed to configure authentication options: invalid 'ssh' auth option: 'identity' is required

After:

╷
│ Warning: Flux resources GitRepository and Kustomization in flux-system namespace are not ready and Flux will be redeployed
│ 
│   with module.user_flux.flux_bootstrap_git.flux,
│   on ../../../common/flux/main.tf line 15, in resource "flux_bootstrap_git" "flux":
│   15: resource "flux_bootstrap_git" "flux" {
│ 
│ GitRepository/flux-system: failed to configure authentication options: invalid 'ssh' auth option: 'identity' is required
╵

Signed-off-by: Ilya Dmitrichenko <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @errordeveloper 🏅

@stefanprodan stefanprodan added the area/kubernetes Kubernetes bootstrap related issues and pull requests label May 2, 2024
@stefanprodan stefanprodan merged commit 346400d into fluxcd:main May 2, 2024
8 checks passed
Copy link
Member

@swade1987 swade1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @errordeveloper 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes bootstrap related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants