Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Controller sharding and horizontal scaling #1444

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 4, 2023

@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Apr 4, 2023
@stefanprodan stefanprodan requested a review from makkes April 4, 2023 09:37
@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label Apr 4, 2023
@stefanprodan stefanprodan force-pushed the docs-sharding branch 4 times, most recently from f2d26e9 to bb3c6ba Compare April 4, 2023 13:37
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great guide! I added some suggestions, mainly around a more active/call-to-action tone.

@@ -2,7 +2,7 @@
title: "Bootstrap cheatsheet"
linkTitle: "Bootstrap"
description: "Showcase various configurations of Flux controllers at bootstrap time."
weight: 30
weight: 29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to rather sort the pages in here alphabetically so users can skip through them visually more easily?

touch clusters/my-cluster/flux-system/shard1/kustomization.yaml
```

### Configure controller sharding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel all these steps should rather be a numbered list. Alternatively enumerate the headings like ### 2. Configure controller sharding

content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
patch: |
- op: add
path: /spec/template/spec/containers/0/args/0
value: --watch-label-selector=sharding.fluxcd.io/key notin (shard1, shard2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason there's trailing spaces at the end of this line in the rendered output.

content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
content/en/flux/cheatsheets/sharding.md Outdated Show resolved Hide resolved
Co-authored-by: Max Jonas Werner <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Co-authored-by: Sunny <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit ec4ac70 into main Apr 6, 2023
@stefanprodan stefanprodan deleted the docs-sharding branch April 6, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests hold Issues and pull requests put on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants