Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust-analyzer error test #21

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Fix rust-analyzer error test #21

merged 2 commits into from
Jun 18, 2024

Conversation

okhsunrog
Copy link
Contributor

When adding this project to RustRover IDE or VS Code rust-analyzer runs on project sync. It fails with this message:

error[E0308]: mismatched types
   --> /home/okhsunrog/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/test_result.rs:102:18
    |
101 |         None => match status.signal() {
    |                       --------------- this expression has type `Option<i32>`
102 |             Some(libc::SIGABRT) => TestResult::TrFailed,
    |                  ^^^^^^^^^^^^^ expected `i32`, found `usize`

I suggest adding harness = false to disable these checks.
You can take a look here, for example:
rust-lang/rust#125714
esp-rs/esp-idf-template@d084765

The commit in my branch fixes the issue.

@fmckeogh
Copy link
Owner

fmckeogh commented Jun 18, 2024

LGTM, thanks! Do you mind fixing the CI error and I'll merge this in?:)

@okhsunrog
Copy link
Contributor Author

Sure, I'll fix it

@okhsunrog
Copy link
Contributor Author

fixed

@fmckeogh fmckeogh merged commit 543e166 into fmckeogh:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants