-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running Pluto with Malt.jl inside CI tests does not update code coverage #2818
Comments
disberd
changed the title
Running Pluto inside Package tests does not increase code coverage with Malt.jl
Running Pluto with Malt.jl inside CI tests does not update code coverage
Feb 19, 2024
Thanks! This is an intentional difference between Malt and Distributed: Malt does not inherit the command line flags of the parent process, including |
I didn't realize this was a julia flag :D. Thanks I'll make a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is not a direct issue to Pluto itself, but I thought it would be good to mention it in case someone else experience this.
I am running non-interactive Pluto sessions as part of CI tests in https:/disberd/PlutoDevMacros.jl
After a while not submitting a PR anymore, I noticed a couple days ago that for my new PR, all of the parts of code only tested via the Pluto session did not appear as covered anymore despite being so in the previous CI run (a few months back).
Today as part of another PR I did think it could be related to recent versions of Pluto defaulting to Malt.jl rather than Distributed to run notebook code.
This commit simply set the flag to use distributed instead of Malt and indeed my code coverage went back up to around 95% correctly considering all of the code being only tested as part of a non-interactive Pluto session.
Just leaving this here in case someone else does run Pluto sessions as part of testing and saw the CI coverage drop.
The text was updated successfully, but these errors were encountered: