fix: minor foo

foodcoops · Jan 2, 2023 · d12ce99 · d12ce99
1 parent 86983b7
commit d12ce99
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/spec/requests/api/order_articles_spec.rb b/spec/requests/api/order_articles_spec.rb
@@ -46,7 +46,7 @@
  end
  end
 
- describe 'supplier' do
+ describe 'when ordered by supplier' do
  let(:q) { { q: { ordered: 'supplier' } } }
 
  run_test! do |response|
@@ -56,7 +56,7 @@
  end
  end
 
- describe 'member' do
+ describe 'when ordered by member' do
  let(:q) { { q: { ordered: 'member' } } }
 
  run_test! do |response|

diff --git a/spec/requests/api/user/financial_transactions_spec.rb b/spec/requests/api/user/financial_transactions_spec.rb
@@ -91,10 +91,7 @@
  response '200', 'success' do
  schema type: :object, properties: {
  financial_transaction: {
- type: :object,
- items: {
- '$ref': '#/components/schemas/FinancialTransaction'
- }
+ '$ref': '#/components/schemas/FinancialTransaction'
  }
  }
  let(:id) { ft.id }

diff --git a/spec/requests/api/user/users_spec.rb b/spec/requests/api/user/users_spec.rb
@@ -53,6 +53,7 @@
  tags 'User', 'Financial Transaction'
  produces 'application/json'
  let(:user) { create :user, :ordergroup }
+ let(:api_scopes) { ['finance:user'] }
  FinancialTransactionClass.create(name: 'TestTransaction')
 
  response 200, 'success' do
@@ -93,7 +94,6 @@
  }
  }
 
- let(:api_scopes) { ['finance:user'] }
  run_test!
  end
 

diff --git a/spec/support/api_helper.rb b/spec/support/api_helper.rb
@@ -79,7 +79,12 @@ def self.pagination_param
  def self.q_ordered_url_param
  parameter name: :q, in: :query, required: false,
  description: "'member' show articles ordered by the user's ordergroup, 'all' by all members, and 'supplier' ordered at the supplier",
- schema: { '$ref' => '#/components/schemas/q_ordered' }
+ schema: {
+ type: :object,
+ properties: {
+ ordered: { '$ref' => '#/components/schemas/q_ordered' }
+ }
+ }
  end
  end
 end