-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit article user-interface update + unit_subdivision #209
Labels
Comments
wvengen
added a commit
to foodcoop-adam/foodsoft
that referenced
this issue
Nov 20, 2013
I plan to make these changes, except the subdivision unit, which we can discuss here. |
@bennibu what do you think, does this make sense, is there a better track? |
Just one comment concerning the gray box style: It looks similar to a |
hmm true - I'll see how an expander button "subdivide" showing the input looks (with or without show-fully-on-hover) |
17 tasks
moving to foodcoop-adam#101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The edit article form could be somewhat clearer. These proposed changes are mostly straightforward, just better use of existing space (plus the addition of the gross price - which could even be updated dynamically after changing a price component).
One thing is a change from existing behaviour, and that's the third field on the "Unit" line, shown in light-grey by default. This is a proposed new unit_divide field, which foodcoops can use to indicate they want to subdivide a supplier's unit into smaller bits. When equal to the unit, the box is shown in light-grey, when different it's shown normally. Members will be able to order multiples of unit_divide, irregardless of the supplier's unit.
Foodsoft's current approach is that foodcoops can modify their unit when they want a different distribution unit than the supplier gives. Either they update unit_quantity and price themselves, or they use the shared database synchronisation feature, which compares the article's unit with the shared article's unit, and recomputes the article's unit quantity and price.
My proposal is the addition of a unit_subdivide field, because a) a clear user-interface, b) the possibility for foodcoops to see which articles they need to subdivide and for which they can distribute using existing packages.
This is a user-interface proposal. I'm confident that this can be implemented in the model-side as well (most notably, the distribution of articles and the remaining units calculation; this may include the addition of another field caching the ratio of unit : unit_subdivide).
p.s. This is missing the article availability checkbox. I'm not sure where to put it. Maybe even in the modal's title right aligned?
The text was updated successfully, but these errors were encountered: