Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.6.99] Transaction collections ignores decimals #722

Open
twothreenine opened this issue Feb 26, 2020 · 3 comments
Open

[v4.6.99] Transaction collections ignores decimals #722

twothreenine opened this issue Feb 26, 2020 · 3 comments

Comments

@twothreenine
Copy link
Contributor

When entering transactions via finance/transactions/new_collection, the amounts are processed as integers, ignoring the decimals. Only by entering singular transactions to a specific ordergroup, it is possible to enter amounts with decimals.

@twothreenine
Copy link
Contributor Author

I found out that it works with decimal point, just not with decimal comma.
Entering a singular transaction works both with decimal point and decimal comma.
There are more cases in which only decimal point works, like received units per group in an order:
split-

And then there is a case where decimal point seems to work at first, but it is not processed: On the "receive" page
receive
After submitting, the numbers are rounded to the nearest integers.

@wvengen
Copy link
Member

wvengen commented Aug 6, 2020

Thanks for your bug report. That's quite odd, especially the receive screen-case.
The code used for allowing both comma and point is really old, it might suffer from bit-rot. Would be good to review.
The database should have a decimal for these fields.

@twothreenine
Copy link
Contributor Author

When entering transactions via finance/transactions/new_collection, the amounts are processed as integers, ignoring the decimals. Only by entering singular transactions to a specific ordergroup, it is possible to enter amounts with decimals.

This has been resolved in #921 👍

Could we use a similar logic to fix the balancing menu case, too, or is that a different problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants