Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add textual diff for strings. fix #20 #25

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Conversation

andreineculau
Copy link
Member

NOTE: a backwards-incompatible change, a failure now has expected, actual value, but also "details" (in this case, a text_diff detail)

An example of the new JSON output

      "errors": [
        {
          "reason": "not_equal",
          "key": "/body/args/whoarewe",
          "expected": "asdMikeJoe",
          "actual": "Mike_and_Joe",
          "text_diff": [
            {
              "del": "asd"
            },
            {
              "eq": "Mike"
            },
            {
              "ins": "_and_"
            },
            {
              "eq": "Joe"
            }
          ]
        }
      ]

andreineculau added a commit that referenced this pull request Feb 15, 2016
add textual diff for strings. fix #20
@andreineculau andreineculau merged commit 4b847ba into develop Feb 15, 2016
@andreineculau andreineculau deleted the andrein/diff branch March 7, 2016 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant