This repository has been archived by the owner on May 4, 2020. It is now read-only.
feat(@formatjs/intl-unified-numberformat): add currencyDisplay… #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlho
suggested changes
Dec 1, 2019
pyrocat101
force-pushed
the
numberFormat-currencyDisplay
branch
from
e3fa88c
to
9720fcc
Compare
longlho
approved these changes
Dec 2, 2019
longlho
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for new
narrowSymbolvalue of thecurrencyDisplayoption toUnifiedNumberFormat.Implementation-wise, it depends on 2 assumptions:
symbolis equivalent to falling back to ISO currency code as instructed in the spec.formatToParts.Both of these assumptions are verified with a script
scripts/assert_currency_symbols.tsagainst Google Chrome 78.If a number is to be formatted to
narrowSymbolcurrency, then first this is formatted to parts withcurrencyDisplay: 'symbol'option, and then the code simply replaces the occurrence ofcurrencytype in the parts with the narrow symbol counterpart if it is available for the specified locale + currency combination.