Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[FastField]: initial values in case of radio and checkbox #2874

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

maddhruv
Copy link
Collaborator

@maddhruv maddhruv commented Nov 7, 2020

Resolves - #2297

As FastField doesn't set initial values when the input type is radio or checkbox

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2020

🦋 Changeset detected

Latest commit: 66e3081

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/formik/d4nnoo2jp
✅ Preview: https://formik-git-fix-fastfield-initialvalues-radio-checkbox.formium.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

Size Change: -138 B (0%)

Total Size: 41 kB

Filename Size Change
packages/formik/dist/formik.cjs.development.js 16.5 kB -49 B (0%)
packages/formik/dist/formik.cjs.production.min.js 7.08 kB -32 B (0%)
packages/formik/dist/formik.esm.js 16.4 kB -57 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/formik-native/dist/formik-native.cjs.development.js 306 B 0 B
packages/formik-native/dist/formik-native.cjs.production.min.js 242 B 0 B
packages/formik-native/dist/formik-native.esm.js 238 B 0 B
packages/formik-native/dist/index.js 150 B 0 B
packages/formik/dist/index.js 143 B 0 B

compressed-size-action

@jaredpalmer
Copy link
Owner

Can you add a changeset ?

@maddhruv
Copy link
Collaborator Author

maddhruv commented Nov 7, 2020

@jaredpalmer added the changelog

@maddhruv
Copy link
Collaborator Author

maddhruv commented Nov 9, 2020

@all-contributors please add maddhruv for bug code content doc example ideas projectManagement question review

@allcontributors
Copy link

@maddhruv

I've put up a pull request to add @maddhruv! 🎉

@johnrom
Copy link
Collaborator

johnrom commented Nov 9, 2020

@maddhruv @jaredpalmer this changeset migrated FastField from using formik.handleChange to field.onChange which could technically be a breaking change. Just a note in case we see FastField issues pop up.

@jaredpalmer
Copy link
Owner

Oof you’re totally right. Shoot

@royhadad
Copy link

how can I get this fix in my own project? is there a specific version I need to install? currently using 2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants