Bugfix: updateInputsWithValue doesn't update nested field (#604)

formsy · Jan 22, 2021 · e2fc916 · e2fc916
1 parent 880ab7a
commit e2fc916
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 6 deletions.
diff --git a/__tests__/Formsy.spec.tsx b/__tests__/Formsy.spec.tsx
@@ -687,6 +687,37 @@ describe('value === false', () => {
  expect(getWrapperInstance(inputs.at(1)).getValue()).toEqual(true);
  });
 
+ it('should be able to set a deep value with updateInputsWithValue', () => {
+ class TestForm extends React.Component<{}, { valueBar: number; valueFoo: { valueBar: number }}> {
+ constructor(props) {
+ super(props);
+ this.state = {
+ valueFoo: { valueBar: 1 },
+ valueBar: 2,
+ };
+ }
+
+ render() {
+ return (
+ <Formsy>
+ <TestInput name="foo.bar" value={this.state.valueFoo.valueBar} />
+ <TestInput name="bar" value={this.state.valueBar} />
+ <button type="submit">Save</button>
+ </Formsy>
+ );
+ }
+ }
+
+ const form = mount(<TestForm />);
+ const inputs = form.find('Formsy(TestInput)');
+ const formsyForm = form.find(Formsy);
+ expect(getWrapperInstance(inputs.at(0)).getValue()).toEqual(1);
+ expect(getWrapperInstance(inputs.at(1)).getValue()).toEqual(2);
+ getFormInstance(formsyForm).updateInputsWithValue({ foo: { bar: 3 }, bar: 4 });
+ expect(getWrapperInstance(inputs.at(0)).getValue()).toEqual(3);
+ expect(getWrapperInstance(inputs.at(1)).getValue()).toEqual(4);
+ });
+
  it('should be able to reset the form using custom data', () => {
  class TestForm extends React.Component<{}, { value: number; valueDeep: number }> {
  constructor(props) {

diff --git a/src/Formsy.ts b/src/Formsy.ts
@@ -408,12 +408,11 @@ export class Formsy extends React.Component<FormsyProps, FormsyState> {
  };
 
  // Set the value of components
- public updateInputsWithValue: IUpdateInputsWithValue<any> = (values, validate) => {
- Object.entries(values).forEach(([name, value]) => {
- const input = this.inputs.find((component) => component.props.name === name);
-
- if (input) {
- input.setValue(value, validate);
+ public updateInputsWithValue: IUpdateInputsWithValue<any> = (data, validate) => {
+ this.inputs.forEach((component) => {
+ const { name } = component.props;
+ if (data && has(data, name)) {
+ component.setValue(get(data, name), validate);
  }
  });
  };