-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernizing the tests #115
Comments
I think Jest is the clear winner here, as far as the standards. The upgrade should be relatively easy. I think I'll make this my next task once most merges are done. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nodeunit is depracated, as detailed in the library's readme https:/caolan/nodeunit
It's a big wtf moment for anyone wanting to contribute who is used to Mocha or Jest. Contributors with no experience would be learning something they would be unlikely to use in another project.
I'm thinking either Mocha/Sinon/Chai combo or Jest, both with Enzyme. Jest is the more popular option, but if we use the other stack we wouldn't have to rewrite the Sinon spies which are already used by current Formsy tests. I also prefer Chai's assertion format personally.
Anyone else have any opinions?
The text was updated successfully, but these errors were encountered: