Fix deprecated lifecycle method usage in tests #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix async tests that not used done and passed without a good reason :]
felixmosh
commented
Dec 22, 2019
|
|
||
| // Wait before adding the input | ||
| setTimeout(() => { |
There was a problem hiding this comment.
without usage of done in this test, it will always pass!
felixmosh
commented
Dec 22, 2019
| // Wait for next event loop, as that does the form | ||
| immediate(() => { | ||
| form.simulate('submit'); | ||
| test.ok('test' in model); |
There was a problem hiding this comment.
As prove of the comment, test.ok is not exists but it is never run so the test not explodes => pass
🙁
|
Thank you so much! These are fantastic updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix async tests that not used done and passed without a good reason :]
I will try to remove all tests warnings as there are many of them in future PRs