Remove unused Formsy props; tighten types; improve runRules #392

rkuykendall · 2020-02-16T01:02:13Z

Simplify and improve runRules function
Remove unused Formsy props
Tighten types and remove as many anys as possible
Add undocumented props to documentation

Closes #390

twisty · 2020-02-16T01:24:34Z

src/Wrapper.ts

- errorMessage: any;
- errorMessages: any;
+ errorMessage: string;
+ errorMessages: string[];


We haven't explicitly said that errorMessage(s) should be strings until now? Perhaps ReactNode would be better – (I think that encompasses string)? This would prevent breakage if users were passing something else renderable like a React element/component as an error message?

Interesting observation! I don't see why not. Good catch. I'll add to a PR I'm doing now.

I really appreciate your reviews. It doesn't seem like there's enough activity on formsy-react to get all my PRs reviewed but I find any comments you can find time to make very very helpful.

rkuykendall added 2 commits February 15, 2020 19:22

Simplify and improve runRules function

ec30a57

Remove unused Formsy props and tighten types

5a99fa9

rkuykendall merged commit 0eaeef7 into master Feb 16, 2020

rkuykendall deleted the deep-improvements branch February 16, 2020 01:04

twisty reviewed Feb 16, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused Formsy props; tighten types; improve runRules #392

Remove unused Formsy props; tighten types; improve runRules #392

rkuykendall commented Feb 16, 2020 •

edited

Loading

twisty Feb 16, 2020

rkuykendall Feb 16, 2020

Remove unused Formsy props; tighten types; improve runRules #392

Remove unused Formsy props; tighten types; improve runRules #392

Conversation

rkuykendall commented Feb 16, 2020 • edited Loading

twisty Feb 16, 2020

Choose a reason for hiding this comment

rkuykendall Feb 16, 2020

Choose a reason for hiding this comment

rkuykendall commented Feb 16, 2020 •

edited

Loading