Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow errors in UpdateInputsWithError method to be React elements #468

Merged
merged 1 commit into from
May 5, 2020

Conversation

helluvalazyass
Copy link
Contributor

@helluvalazyass helluvalazyass commented May 5, 2020

( Assign ValidationError type to errors in updateInputsWithError method #455 )

  • Title is human readable, as it will be included directly in CHANGELOG.md when we do a release
  • If this is a new user-facing feature, documentation has been added to API.md
  • Any dist/ changes have not been committed.

Tests run directly on the source code and all dist changes are computed and committed during Formsy release.

@rkuykendall
Copy link
Member

wow, that was even easier than expected! Nice job, and thanks for the PR!

@rkuykendall rkuykendall merged commit 63df277 into formsy:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants