Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(onchange): Form onChange prop honors dot notation nesting, matching submit prop #48

Closed
wants to merge 1 commit into from
Closed

fix(onchange): Form onChange prop honors dot notation nesting, matching submit prop #48

wants to merge 1 commit into from

Conversation

th3fallen
Copy link

@th3fallen th3fallen commented Dec 14, 2017 •
edited by rkuykendall
Loading

BREAKING CHANGE: Change form level onChange function to honor dot notation nesting

Fixes: #47

@rkuykendall rkuykendall changed the title fix form level onchange not honoring dot notation nesting fix(onchange): Form onChange prop honors dot notation nesting, matching submit prop Dec 17, 2017
@rkuykendall
Copy link
Member

Changed title/description to match Conventional Commits the best I understand them (still new to me).

rkuykendall
rkuykendall approved these changes Dec 17, 2017
View reviewed changes
Copy link
Member

@rkuykendall rkuykendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I would hold off merging until we decide what release we want this in. I'll post about that in the issue.

@MilosRasic
Copy link
Contributor

I'm a bit worried that calling getModel() instead of getCurrentValues() might impact performance in a bad way. getCurrentValues() already does a reduce, and getModel calls getCurrentValues() then mapModel() which does another reduce.

Maybe we could memoize mapModel()?

This was referenced Feb 8, 2018
Closed
Closed
MilosRasic added a commit that referenced this pull request May 22, 2018
@MilosRasic
merged #48
957d7e6
@MilosRasic
Copy link
Contributor

merged into v2.0

@MilosRasic MilosRasic closed this May 22, 2018
@th3fallen th3fallen deleted the fix/form-onchange-honor-dot-notation-nesting branch May 22, 2018 15:18
@MilosRasic MilosRasic mentioned this pull request May 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuykendall rkuykendall rkuykendall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@th3fallen @rkuykendall @MilosRasic