Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to react testing lib instead of enzyme #679

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Jul 24, 2022

( what is the feature, or what is it this is PR fixing? )

  • Title is human readable, as it will be included directly in CHANGELOG.md when we do a release
  • If this is a new user-facing feature, documentation has been added to API.md
  • Any dist/ changes have not been committed.

Tests run directly on the source code and all dist changes are computed and committed during Formsy release.

I've migrated all the tests to use react testing lib, in the process found some tests that were false, and testing implementation details.

This will allows as to review adding support for React 18 (enzyme doesn't supports it)

Copy link
Member

@rkuykendall rkuykendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Not just the massive upgrade, but also the small code improvements peppered throughout.

@rkuykendall
Copy link
Member

Thank you for asking me to take a look, it was a pleasure to read.

@felixmosh felixmosh merged commit 901aed2 into master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants