Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for React 18 #692

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Add support for React 18 #692

merged 1 commit into from
Nov 8, 2022

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Nov 8, 2022

Added React 18 as peer deps and tested it.

  • Title is human readable, as it will be included directly in CHANGELOG.md when we do a release
  • If this is a new user-facing feature, documentation has been added to API.md

@rkuykendall wdyt? should we trust ower tests? :]

@rkuykendall
Copy link
Member

@felixmosh I think so. If something fails, we can add a new test! I'd remove the build artifacts from this though as they are generated on release.

@felixmosh
Copy link
Contributor Author

Done :]

@felixmosh felixmosh merged commit 34ba66d into master Nov 8, 2022
@felixmosh felixmosh deleted the react-18-migration branch December 6, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants