Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version to test #416

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Version to test #416

wants to merge 20 commits into from

Conversation

digrapsas
Copy link

Hi @gnikit, the previous merge request closed automatically because I had to force merge the origin branch to keep my fork up to date.

The feature has been tested for a few weeks now on a daily basis on my project, it is working pretty well. Of course there are improvements that could be discussed, I bring some minor modifications from time to time. Let me know whenever you have time to check on this.

I haven't been able to check the issue with the CI tests, I have little experience on this but I'll try to have a quick look soon.

Regrards

@digrapsas digrapsas requested a review from gnikit as a code owner June 20, 2024 09:25
@digrapsas
Copy link
Author

@gnikit I when I type the command you proposed to update intrinsics,

python3 -m fortls.parsers.internal.intrinsics

I get the following error: RuntimeWarning: 'fortls.parsers.internal.intrinsics' found in sys.modules after import of package 'fortls.parsers.internal', but prior to execution of 'fortls.parsers.internal.intrinsics'; this may result in unpredictable behaviour

In the beginning I thought this was some issue with my dependencies, but I tried from another computer and on the mother branch, but still got the same issue. Let me know if you have any idea of how this could be fixed,

Regards

@digrapsas
Copy link
Author

Hi @gnikit,

This is just a reminder of this activity waiting to be reviewed and eventually merged.

I have been testing the folding range since a couple of months now on a large scale industrial code, and it has been working without any issues.

Let me know if you have some time to take care of this,

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant