Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split out modules for separate concerns #172

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wpbonelli
Copy link

@wpbonelli wpbonelli commented Mar 10, 2024

  • organize the codebase into modules
  • use absolute instead of relative imports
  • no need for classes to inherit from object
  • use consistent camel case for class names
  • remove imports from __future__ from test script (not needed)
  • run black and isort on python files (responsible for LOC increase)
  • add .DS_Store to .gitignore
  • miscellaneous tidying

This should not introduce any functional changes — see passing tests on my fork

todo: tests to pytest

* organize the codebase into modules
* use absolute instead of relative imports
* no need for classes to inherit from object
* use consistent camel case for class names
* remove imports from __future__ from test script (not needed)
* run black and isort on python files
* add .DS_Store to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant