Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fourmolu and cabal-fmt updates #1471

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fourmolu and cabal-fmt updates #1471

merged 3 commits into from
Sep 17, 2024

Conversation

spatten
Copy link
Contributor

@spatten spatten commented Sep 17, 2024

Overview

fossas/haskell-dev-tools#56 updated the version of fourmolu and cabal-fmt that we use in CI.

This PR reformats all .hs and .cabal files with the new versions of these formatters.

Acceptance criteria

  • The lint checks pass
  • If you are using the correct version of the linter locally, you format the file properly locally

Testing plan

Get the right version of the tool installed locally:

ghcup install ghc 9.8
ghcup set ghc 9.8
cabal update
cabal build

cabal install fourmolu --overwrite-policy=always
cabal install cabal-fmt --overwrite-policy=always

Run make fmt-haskell

You should see no changes.

Risks

Metrics

References

fossas/haskell-dev-tools#56

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@spatten spatten changed the title run fourmolu on all haskell and cabal files fourmolu and cabal-fmt updates Sep 17, 2024
@spatten spatten marked this pull request as ready for review September 17, 2024 22:12
@spatten spatten requested a review from a team as a code owner September 17, 2024 22:12
@spatten spatten merged commit 2633303 into master Sep 17, 2024
19 checks passed
@spatten spatten deleted the fourmolu-updates branch September 17, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants