Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscription check on fossa report preflight check #1474

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

JeffreyHuynh1
Copy link
Contributor

@JeffreyHuynh1 JeffreyHuynh1 commented Sep 23, 2024

Overview

fossa report fails for free tier users. This shouldn't be the case with the changes to our free plan: https://fossa.com/blog/secure-open-source-fossa-upgraded-free-plan/ . We are currently failing because our preflight checks for fossa report are still configured to check if users have a premium subscription type. Remove this preflight check to account for FOSSA's free plan changes.

Slack threads:

Acceptance criteria

  • fossa report works for free tier users

Testing plan

With a free tier account, do the following:

  • fossa analyze
  • fossa report attribution --format html

Screenshot 2024-09-23 at 4 44 16 PM

Risks

Metrics

References

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@JeffreyHuynh1 JeffreyHuynh1 marked this pull request as ready for review September 24, 2024 00:15
@JeffreyHuynh1 JeffreyHuynh1 requested a review from a team as a code owner September 24, 2024 00:15
Copy link
Member

@zlav zlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe. The only real change I see is that we no longer check subscription type before someone runs the report command.

@JeffreyHuynh1 JeffreyHuynh1 merged commit 9d8190f into master Sep 30, 2024
19 checks passed
@JeffreyHuynh1 JeffreyHuynh1 deleted the report-preflight-check branch September 30, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants