Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use bytesize for foyer-bench #698

Merged
merged 4 commits into from
Sep 10, 2024
Merged

refactor: use bytesize for foyer-bench #698

merged 4 commits into from
Sep 10, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 10, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#689

@MrCroxx MrCroxx added this to the v0.11 milestone Sep 10, 2024
@MrCroxx MrCroxx self-assigned this Sep 10, 2024
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 10, 2024

New benchmark script:

cargo build --release --features jemalloc && PATH=/home/mrcroxx/.local/bin:$PATH RUST_BACKTRACE=1 RUST_LOG=info flamegraph -- ./target/release/foyer-bench --file /dev/nvme2n1 --mem 64MiB --disk 100GiB --region-size 64MiB --get-range 100000 --flushers 4 --reclaimers 4 --time 60 --writers 256 --w-rate 4MiB --admission-rate-limit 500MiB --readers 32 --r-rate 32MiB --metrics --warm-up 2 --runtime separated --user-runtime-worker-threads 8 --read-runtime-worker-threads 8 --write-runtime-worker-threads 4 --read-runtime-max-blocking-threads 8 --write-runtime-max-blocking-threads 4

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-bench/src/main.rs 58.82% 14 Missing ⚠️
Files with missing lines Coverage Δ
foyer-bench/src/main.rs 66.11% <58.82%> (ø)

@MrCroxx MrCroxx merged commit ea88f87 into main Sep 10, 2024
22 checks passed
@MrCroxx MrCroxx deleted the xx/bytesize branch September 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant