Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine runtime and tracing options #756

Merged
merged 4 commits into from
Oct 8, 2024
Merged

refactor: refine runtime and tracing options #756

merged 4 commits into from
Oct 8, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Oct 8, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Changes

  • Rename RuntimeConfig and TokioRuntimeConfig to RuntimeOptions and TokioRuntimeOptions for consistency.
  • Split TracingConfig to TracingConfig and TracingOptions and refine codes.
  • Refine tracing configuration for foyer-bench.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#327

@MrCroxx MrCroxx added this to the v0.12 milestone Oct 8, 2024
@MrCroxx MrCroxx self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 88.28829% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-bench/src/main.rs 50.00% 9 Missing ⚠️
foyer-common/src/tracing.rs 94.82% 3 Missing ⚠️
foyer-storage/src/store.rs 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer/src/hybrid/builder.rs 95.15% <100.00%> (ø)
foyer/src/hybrid/cache.rs 82.71% <100.00%> (+0.05%) ⬆️
foyer-storage/src/store.rs 86.06% <85.71%> (ø)
foyer-common/src/tracing.rs 87.12% <94.82%> (+4.23%) ⬆️
foyer-bench/src/main.rs 65.29% <50.00%> (-0.33%) ⬇️

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx merged commit 726a5f5 into main Oct 8, 2024
22 checks passed
@MrCroxx MrCroxx deleted the xx/options branch October 8, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant