Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scale shards to 1 when there is not enough capacity #765

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Oct 10, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #764

@MrCroxx MrCroxx added the feature New feature or request label Oct 10, 2024
@MrCroxx MrCroxx added this to the v0.12 milestone Oct 10, 2024
@MrCroxx MrCroxx self-assigned this Oct 10, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) October 10, 2024 07:20
@MrCroxx MrCroxx merged commit 42cdce2 into main Oct 10, 2024
20 checks passed
@MrCroxx MrCroxx deleted the xx/not-enough-capacity branch October 10, 2024 07:31
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/cache.rs 77.77% 4 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/generic.rs 91.04% <100.00%> (+0.05%) ⬆️
foyer-memory/src/cache.rs 85.74% <77.77%> (-0.44%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

refactor: scale in the shards with small capacity and raise a warning
1 participant