Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not scale in shards when capacity is not enough, just warn #769

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Oct 10, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Sometimes, it is still useful.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

fix #768

@MrCroxx MrCroxx added the bug Something isn't working label Oct 10, 2024
@MrCroxx MrCroxx added this to the v0.12 milestone Oct 10, 2024
@MrCroxx MrCroxx self-assigned this Oct 10, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) October 10, 2024 09:47
@MrCroxx MrCroxx merged commit 96581eb into main Oct 10, 2024
19 of 20 checks passed
@MrCroxx MrCroxx deleted the xx/panic branch October 10, 2024 09:58
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/cache.rs 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/generic.rs 90.58% <ø> (-0.47%) ⬇️
foyer-memory/src/cache.rs 84.59% <50.00%> (-1.16%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: panic when capacity is 0
1 participant