Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency_getter): extract requirements files extraction #886

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Extracted from #881. This makes the extraction of dynamic dependencies from setuptools cleaner than having to instantiate RequirementsTxtDependencyGetter.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.4%. Comparing base (3fc6405) to head (3cbf622).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #886     +/-   ##
=======================================
+ Coverage   92.1%   92.4%   +0.2%     
=======================================
  Files         37      37             
  Lines        992     989      -3     
  Branches      96      96             
=======================================
  Hits         914     914             
+ Misses        62      60      -2     
+ Partials      16      15      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review October 11, 2024 13:27
@mkniewallner mkniewallner changed the title refactor: extract requirements files extraction refactor(dependency_getter): extract requirements files extraction Oct 11, 2024
@mkniewallner mkniewallner force-pushed the refactor/extract-requirements-files-extraction branch from c685dfc to 3cbf622 Compare October 15, 2024 17:14
@mkniewallner mkniewallner enabled auto-merge (squash) October 15, 2024 17:17
@mkniewallner mkniewallner merged commit 458eff9 into main Oct 15, 2024
22 checks passed
@mkniewallner mkniewallner deleted the refactor/extract-requirements-files-extraction branch October 15, 2024 19:16
@mkniewallner mkniewallner restored the refactor/extract-requirements-files-extraction branch October 15, 2024 22:34
@mkniewallner mkniewallner deleted the refactor/extract-requirements-files-extraction branch October 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants