Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature_request] Add tau_grav_hat to the franka_state_controller/franka_states #207

Closed
rickstaa opened this issue Nov 25, 2021 · 5 comments

Comments

@rickstaa
Copy link
Contributor

For one of my projects, I was looking for an easy way to retrieve the torque that is applied by Gravity on the panda_joints. I know that I can retrieve this by using the getGravity method of the franka_hw::FrankaModelInterface, but I think it would be a significant improvement if this parameter was included in the franka_states that is published by the franka_state_controller or in a separate topic like is done with the F_ext parameter.

https:/rickstaa/franka_ros/blob/5341770c6db24cdf5acf1bd87e832cf9f60a1b5c/franka_hw/include/franka_hw/franka_model_interface.h#L122

I did not create an example pull request for this since there are several ways to implement this.

@rickstaa
Copy link
Contributor Author

rickstaa commented Nov 25, 2021

Altough, having the gravity torques show up in the franka_states message would be nice in my opinion. Merging #198 will already allow people to infer these torques.

@rickstaa rickstaa changed the title [feature_request] Add tau_grav_hat to the franka_state_controller/franka_states [feature_request] Add control latency effects to FrankaHWsim Nov 26, 2021
@rickstaa rickstaa changed the title [feature_request] Add control latency effects to FrankaHWsim [feature_request] Add tau_grav_hat to the franka_state_controller/franka_states Nov 26, 2021
@rickstaa rickstaa reopened this Nov 26, 2021
@gollth
Copy link
Contributor

gollth commented Dec 7, 2021

Including it in the State Interface wont be an option, really, since this data is not published via the FCI and libfranka. We can only add fields into the franka_states which come directly from the robot.

Providing a topic seems possible, but I wonder how useful that would be. Most often you need this data in realtime for control, not?

What speaks against the "ros_control"-way of doing this, i.e. claiming the model interface and getting the gravity term via getGravity()?

@rickstaa
Copy link
Contributor Author

rickstaa commented Dec 8, 2021

@gollth Ah, if you're not planning to implement this in the FCI, then adding it to the franka_states indeed does not make sense.

There is nothing wrong with using the getGravity() function. I, however, thought publishing these gravity torques on a rostopic would improve user experience. By doing so, users who use the high-level franka_ros package can access this information without interacting with the franka_model_interface through C++.

@gollth
Copy link
Contributor

gollth commented Dec 27, 2021

Would definitely improve user experience but at the cost of diverging interfaces between real robot and simulation I'd say this is not worth it, especially if you can already get this information via the model interface otherwise. Feel free to reopen if new insights arise

@gollth gollth closed this as completed Dec 27, 2021
@rickstaa
Copy link
Contributor Author

rickstaa commented Dec 27, 2021

No problem! I agree.

gollth added a commit that referenced this issue Dec 5, 2022
* commit 'f0ffba1a08a5a1c12e83f58e9599d49a15c1389b':
  CHANGE: Use splash screen & fixed frame for all example Rvizes
  ADD: CHANGELOG entry
  ADD: RViz splash screen
  FIX: Use `$(arg arm_id)` as fixed frame for RVIz display config
  ADD: Use new `robot.launch` in `panda.launch` & `fr3.launch`
  CHANGE: Rename franka_gazebo/launch/{panda -> robot}.launch
  FIX: Use new `feEnsureAsciiFileContents` helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants