Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number filter throwing an error in IE 11 #81

Closed
hammadmansuri opened this issue Dec 13, 2019 · 5 comments
Closed

Number filter throwing an error in IE 11 #81

hammadmansuri opened this issue Dec 13, 2019 · 5 comments

Comments

@hammadmansuri
Copy link

While using number filter like below
{{123 | number('0.00')}}

I'm getting an error saying that,

[Vue warn]: Error in render: "TypeError: Object doesn't support property or method 'sign'"

If I remove number filter, page loads up fine. It's working fine in other browsers. My vue2-filters version is 0.8.0

freearhey added a commit that referenced this issue Dec 13, 2019
Fixes issue #81

It adds Math.sign function in case it does not exists (like with IE11)
@freearhey
Copy link
Owner

Thanks for the report!

I think I've found what the problem is and already made the necessary changes. Please try changing the vue2-filter version to 0.9.1-beta.0 and let me know if the error has disappeared.

@hammadmansuri
Copy link
Author

Great!!

It solved the problem. Thanks @freearhey

Also, I'm new to versioning system. So, how and when this fix will get roll into major version? (As this one is beta, can't use in production build)

@freearhey
Copy link
Owner

Good! I'll try to publish the final version as soon as possible and write here after that.

@hammadmansuri
Copy link
Author

Thanks @freearhey Appreciated

@freearhey
Copy link
Owner

Done, version 0.9.1 available for download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants