Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin the pip version #3859

Closed
heartsucker opened this issue Oct 10, 2018 · 3 comments
Closed

unpin the pip version #3859

heartsucker opened this issue Oct 10, 2018 · 3 comments

Comments

@heartsucker
Copy link
Contributor

Description

In PR #3853, we pinned the pip version to 18.0 to work around pypa/pipenv#2924. We need to roll this change back once a fix is out.
@redshiftzero
Copy link
Contributor

Should we unpin this or should we keep pip version pinned so that future breakage in pipenv doesn't create a scramble?

@conorsch
Copy link
Contributor

I'm fine with unpinning. At the very least, we should at least re-pin, meaning update pip fully, confirm no problems, and commit pin to the new latest.

@zenmonkeykstop
Copy link
Contributor

Unpinned in #5090, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@conorsch @zenmonkeykstop @heartsucker @redshiftzero