Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): encode SSID on xml generation #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

is-equal
Copy link

Description

Fix failure to connect when the wifi has special characters like &.

Motivation and Context

My wifi has an SSID with special characters so when I try to connect I get an error.
Investigating more about the problem and trying to run netsh wlan add profile .\nodeWifiConnect.xml to add the profile generated by node-wifi I get:

An attempt was made to load a program with an incorrect format.

Reading the file and comparing it with the profile generated by Windows 10, I found the difference and applied the fix encoding the special characters on SSID.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactorization (non-functional change which improve code readibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant