Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI for Frigg - Install command for now #322

Conversation

seanspeaks
Copy link
Contributor

@seanspeaks seanspeaks commented Aug 1, 2024

New CLI for Frigg, with the first command being frigg install <apiModuleName>. We'll see where it takes us.

Some ideas/areas of improvement:

  • tests
  • more prompts
  • aws logs interfering
  • more robust colors etc, maybe use some tooling
  • detect where envs are handled and just add there instead of both places
  • make the envs retain their caps case with the app name prefix
  • Add prompts for editing the integration concept
  • Add more commands that would be helpful during development

Need to work on:
[] tests
[] more prompts
[] aws logs interfering
[] more robust colors etc, maybe use some tooling
[] detect where envs are handled and just add there instead of both places
[] make the envs retain their caps case with the app name prefix
[] Add prompts for editing the integration concept
[] Add more commands that would be helpful during development
@seanspeaks
Copy link
Contributor Author

function commitChanges(backendPath, apiModuleName) {
const apiModulePath = path.join(path.dirname(backendPath), 'src', 'integrations', `${apiModuleName}Integration.js`);
try {
execSync(`git add ${apiModulePath}`);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
… templating.

Still needs some finishing work but this should do for now!
@seanspeaks seanspeaks added the minor Increment the minor version when merged label Aug 1, 2024
@seanspeaks seanspeaks marked this pull request as ready for review August 1, 2024 17:49
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@seanspeaks seanspeaks merged commit b0f53c5 into main Aug 6, 2024
6 of 8 checks passed
@seanspeaks seanspeaks deleted the FRI-418_Explore-ability-to-have-a-CLI-as-part-of-devtools-package branch August 6, 2024 03:07
@seanspeaks
Copy link
Contributor Author

🚀 PR was released in v1.2.0 🚀

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants