Fix bug during local running

[seanspeaks]

When running an app locally, the first time an integration record is retrieved by ID and the module-factory is run, the app errors out.

Specifically, getModuleInstanceFromEntityId fails to find the moduleDefinition, only on the first invocation.

After debugging with logs and inspection, it looks like mongoose (current version?) fails to initialize the descriminator decorator on the mongoose object being evaluated (entity['__t'] comes up undefined). Subsequent requests succeed. This makes me believe there's something to do with initializing the mongoDB connection or mongoose collections.

One patch fix here is to force the mongoose object to finish initializing by calling toJSON.

Works locally for me, unclear how to write the test to prove it out.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[d-klotz]

We should create a task to investigate further, this PR fixes the issue but the root cause is still not clear and can probably happen to other methods in there, right?

[seanspeaks]

🚀 PR was released in v1.2.1 🚀

[seanspeaks]

We should create a task to investigate further, this PR fixes the issue but the root cause is still not clear and can probably happen to other methods in there, right?

So created 👍 FRI-459

[MichaelRyanWebber]

@seanspeaks and @d-klotz You're definitely on to something there Sean.

This is the same issue that I had to work around in getInstance:

https:/friggframework/frigg/blob/main/packages/core/module-plugin/auther.js#L119

I also remember seeing this behavior before, I had added the error check but hadn't been seeing the error, so hadn't put it together.

Will be great to get to the root cause