S10 fixes part1 #75
Merged
S10 fixes part1 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 28, 2023 12:24
A missing elif masked the S10E serial number detection, fixed.
We need to parse the return value and compare it to our requested value. Streamlined the code along the way.
Needed for error detection
E3DCs do indeed return an statusflag here (misinterpretation of mine). Use int(enable) directly in this case, the intermediate is not needed.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of fixes done for my HA integration to work cleanly.
partly fixes 73:
S10E Serial number detection did not work, a missing elif masked the corresponding check
A few exported classes were missing (notably SendError for error detection)
Calls to set_power_save have been streamlined a bit for easier usage.