-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is FCS still .NET 4.0? #160
Comments
Recent versions of the FCS assembly have been compiled against .NET 4.5. Should we move it to "net45" in the nuget package? |
why is 4.5 needed? |
The change to use .NET 4.5 came via the integration of updates from visualfsharp.codeplex.com. 24543fb#diff-d81cb596fee05d911235bc8c0730075b Possibly it lets FCS determine the correct location of the .NET 4.5 binaries to reference, see https:/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/ReferenceResolution.fs#L118 Is there any reason not to target .NET 4.5? We continue to target FSharp.Core 4.3.0.0, but that causes an issue too #156 |
Ok. What do you think of putting both in the .nuget? |
That would be awesome. |
How can I help to get this resolved soon? /cc @dsyme |
Hi @forki It's more work, but looking at the feedback above, could you adjust the pull request to build both net40 and net45 versions of the DLL and add both to the nuget package? |
ok will do |
@dsyme It now creates a nuget package for .NET 4.0 and 4.5. but it's twice the size and I'm still wondering why we need the NET 4.5 dll. Anyway it would be cool if you could merge this and release it. I'd like to update FAKE to the latest FCS. |
@forki Love the animated GIF - where do you find these!? Looking at the above discussion, it seems to me that the compiler does exercise the .NET 4.5 MSBuild API, which it uses to help resolve assembly references specified using F# Interactive. I believe these dependencies are currently trimmed out of FCS via CROSS_PLATFORM_COMPILER, (this is done because the MSBuild API implementatin is incomplete on Mono). It would be good to continue to assess if there is any actual functional difference between the .NET 4.0 and .NET 4.5 versions of the DLL, or if the CROSS_PLATFORM_COMPILER trimming has any substantive impact on behavior w.r.t. reference resolution. In the meantime I'm ok with shipping two of them. |
Here is my second trial: #167 |
Fix build.bat on windows
I tried to update FSharp.Formatting to use FCS 0.0.54 but now it complains that FCS is .NET 4.5 even if the nuget folder contains only a net40 folder.
Any ideas what I'm doing wrong?
The text was updated successfully, but these errors were encountered: