-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more data to AssemblyVersionInformation class #822
Comments
My quick prototype here: master...amazingant:add-data-to-AssemblyVersionInformation The full FAKE solution refuses to build on my machine, so I'm not sure if there's any tests I've invalidated, but after swapping out
Unless there's a reason not to, I'll take some time later to add this to |
@amazingant Can you send a PR for this? |
@dsyme I will have to take a look at re-implementing it on Monday morning. I am not sure how much of FAKE has changed in 16 months (knowing forki, probably quite a bit), but GitHub is telling me that the changes cannot be cleanly merged anymore. |
I currently populate my AssemblyInfo files with a smattering of data (most of it provided by default with the ProjectScaffold build.fsx, but with a couple extra values tossed in). The helpful
AssemblyVersionInformation
type definition provided with C# and F# classes (I may be mistaken, but I don't see anything generating this class for VB underCreateVisualBasicAssemblyInfoWithConfig
, despite the comments for it indicating otherwise) currently provides one value.With a few changes to
Fake.AssemblyInfoFile.Attribute
, and some matching changes in each of theCreate<Language>AssemblyInfoWithConfig
functions, would it be possible to include all of the data populated into the AssemblyInfo file? Hopefully including the metadata values?I'm happy to prototype & PR the code changes for this, but I'm not sure what documentation would need to be updated with it.
The text was updated successfully, but these errors were encountered: