Fix encoding of AssemblyInfo as written by ReplaceAssemblyInfoVersions #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function ReplaceAssemblyInfoVersions was reading files with the encoding set by build param or defaulting to the system default. The AssemblyInfo files are always encoded in UTF-8. Therefore, the file encoding that is actually used should not depend on a build param.
forki
added a commit
that referenced
this pull request
Dec 22, 2015
Fix encoding of AssemblyInfo as written by ReplaceAssemblyInfoVersions
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function ReplaceAssemblyInfoVersions was reading files with the
encoding set by build param or defaulting to the system default, as
ReadFile and WriteFile do under the hood.
The AssemblyInfo files are always encoded in UTF-8. Therefore, the file
encoding that is actually used should not depend on a build param.