Correct waiting for android packaging and fix for mono processes encoding #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1213 processes started on mono now always use utf-8 for input/output
alexsorokoletov
changed the title
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1213 processes started on mono now always use utf-8 for input/output
Regarding #1194
I've updated process start function in XamarinHelper to correctly wait for the process to complete and then trace all the output. Unfortunately, I was not able to find out why asyncShellExec is not working as expected. My gut feeling is that the problem is somehow related with Mono 4.4.0 release (before I had no problem with build processes.
Regarding #1213
I had sometimes problem with the encoding of some of the tools output (curl, jarsigner, zipalign).
Started to look into this because of the #1194 issue I had and found out that fix for #1213 didn't cover all the process start functions and
XamarinHelper.fswas not using the correct one.Appreciate any feedback and suggestions how to make the PR better.