[WIP] Restore the output encoding #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer this one. Is there a reason this is still WIP? |
|
merging, because it looks good to me :) |
|
@matthid I thought I should add some error handling, but I guess we can do that when some bug reports arrive 😄 |
|
Released in alpha010 |
inosik
added a commit
to inosik/FAKE
that referenced
this pull request
Jun 12, 2017
PR fsprojects#1580 didn't restore the previous encoding but the value from `Fake.EnvironmentHelper.encoding`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1562, trying to fix #1461.
I will try this tomorrow on my Windows machine at work.